Messages in this thread | | | From | Linus Walleij <> | Date | Tue, 3 Oct 2023 22:49:10 +0200 | Subject | Re: [RFC 1/4] pinctrl: define PIN_CONFIG_INPUT |
| |
Hi Takahiro,
On Mon, Oct 2, 2023 at 4:17 AM AKASHI Takahiro <takahiro.akashi@linaro.org> wrote:
> This allows for enabling SCMI pinctrl based GPIO driver to obtain > an input gpio pin. > > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> (...) > + * @PIN_CONFIG_INPUT: This will obtain a value on an input pin. The returned > + * argument indicates the value.
We need to specify that this is the inverse of @PIN_CONFIG_OUTPUT, that setting a line into *input mode* requires the use of @PIN_CONFIG_INPUT_ENABLE, so the config can never be set but should return an error on set, and that the argument returned is 1 for logic high and 0 for logic low.
Otherwise I think this is fine!
Yours, Linus Walleij
| |