Messages in this thread Patch in this message | | | From | Li Zhijian <> | Subject | [PATCH] cxl/region: Fix cxl_region_rwsem lock held when returning to user space | Date | Wed, 25 Oct 2023 16:54:50 +0800 |
| |
goto out to release cxl_region_rwsem. Fix below warning: ================================================ WARNING: lock held when returning to user space! 6.6.0-rc3-lizhijian+ #213 Not tainted ------------------------------------------------ cxl/673 is leaving the kernel with locks still held! 1 lock held by cxl/673: #0: ffffffffa013b9d0 (cxl_region_rwsem){++++}-{3:3}, at: commit_store+0x7d/0x3e0 [cxl_core]
Fixes: d1257d098a5a ("cxl/region: Move cache invalidation before region teardown, and before setup") Signed-off-by: Li Zhijian <lizhijian@fujitsu.com> --- drivers/cxl/core/region.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c index 6d63b8798c29..18da77f8f22b 100644 --- a/drivers/cxl/core/region.c +++ b/drivers/cxl/core/region.c @@ -294,7 +294,7 @@ static ssize_t commit_store(struct device *dev, struct device_attribute *attr, */ rc = cxl_region_invalidate_memregion(cxlr); if (rc) - return rc; + goto out; if (commit) { rc = cxl_region_decode_commit(cxlr); -- 2.29.2
| |