Messages in this thread | | | Date | Tue, 24 Oct 2023 23:19:26 +0900 (JST) | Subject | Re: [PATCH net v2] tipc: Fix uninit-value access in tipc_nl_node_reset_link_stats() | From | Shigeru Yoshida <> |
| |
On Mon, 23 Oct 2023 15:53:14 -0700, Jakub Kicinski wrote: > On Sat, 21 Oct 2023 01:34:15 +0900 Shigeru Yoshida wrote: >> Link names must be null-terminated strings. If a link name which is not >> null-terminated is passed through netlink, strstr() and similar functions >> can cause buffer overrun. This causes the above issue. > > If strings need to be null-terminated you should switch the policy here > https://elixir.bootlin.com/linux/v6.6-rc6/source/net/tipc/netlink.c#L91 > from NLA_STRING to NLA_NUL_STRING, no?
Thank you so much for the feedback. As I'm not so familiar with Netlink, I'll study NLA_NUL_STRING a bit more and make an updated patch.
Thanks, Shigeru
> -- > pw-bot: cr >
| |