Messages in this thread | | | Date | Mon, 23 Oct 2023 15:53:14 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH net v2] tipc: Fix uninit-value access in tipc_nl_node_reset_link_stats() |
| |
On Sat, 21 Oct 2023 01:34:15 +0900 Shigeru Yoshida wrote: > Link names must be null-terminated strings. If a link name which is not > null-terminated is passed through netlink, strstr() and similar functions > can cause buffer overrun. This causes the above issue.
If strings need to be null-terminated you should switch the policy here https://elixir.bootlin.com/linux/v6.6-rc6/source/net/tipc/netlink.c#L91 from NLA_STRING to NLA_NUL_STRING, no? -- pw-bot: cr
| |