Messages in this thread Patch in this message | | | From | AceLan Kao <> | Subject | [PATCH v2] mtd: spi-nor: Improve reporting for software reset failures | Date | Tue, 24 Oct 2023 15:43:32 +0800 |
| |
From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
When the software reset command isn't supported, we now report it as an informational message(dev_info) instead of a warning(dev_warn). This adjustment helps avoid unnecessary alarm and confusion regarding software reset capabilities.
v2. only lower the priority for the not supported failure
Signed-off-by: Chia-Lin Kao (AceLan) <acelan.kao@canonical.com> --- drivers/mtd/spi-nor/core.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c index 1b0c6770c14e..76920dbc568b 100644 --- a/drivers/mtd/spi-nor/core.c +++ b/drivers/mtd/spi-nor/core.c @@ -3252,7 +3252,10 @@ static void spi_nor_soft_reset(struct spi_nor *nor) ret = spi_mem_exec_op(nor->spimem, &op); if (ret) { - dev_warn(nor->dev, "Software reset failed: %d\n", ret); + if (ret == -ENOTSUPP) + dev_info(nor->dev, "Software reset enable command doesn't support: %d\n", ret); + else + dev_warn(nor->dev, "Software reset failed: %d\n", ret); return; } @@ -3262,7 +3265,10 @@ static void spi_nor_soft_reset(struct spi_nor *nor) ret = spi_mem_exec_op(nor->spimem, &op); if (ret) { - dev_warn(nor->dev, "Software reset failed: %d\n", ret); + if (ret == -ENOTSUPP) + dev_info(nor->dev, "Software reset command doesn't support: %d\n", ret); + else + dev_warn(nor->dev, "Software reset failed: %d\n", ret); return; } -- 2.34.1
| |