Messages in this thread | | | Date | Mon, 23 Oct 2023 15:01:21 -0700 | Subject | Re: [PATCH iwl-next 2/3] i40e: Add other helpers to check version of running firmware and AQ API | From | Jacob Keller <> |
| |
On 10/23/2023 9:29 AM, Ivan Vecera wrote: > Add another helper functions that will be used by subsequent > patch to refactor existing open-coded checks whether the version > of running firmware and AdminQ API is recent enough to provide > certain capabilities. > > Signed-off-by: Ivan Vecera <ivecera@redhat.com> > --- > drivers/net/ethernet/intel/i40e/i40e_type.h | 54 +++++++++++++++++++++ > 1 file changed, 54 insertions(+) > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h > index 050d479aeed3..bb62c14aa3d4 100644 > --- a/drivers/net/ethernet/intel/i40e/i40e_type.h > +++ b/drivers/net/ethernet/intel/i40e/i40e_type.h > @@ -608,6 +608,60 @@ static inline bool i40e_is_aq_api_ver_ge(struct i40e_hw *hw, u16 maj, u16 min) > (hw->aq.api_maj_ver == maj && hw->aq.api_min_ver >= min)); > } >
This has a bunch of checkpatch.pl warnings if you wouldn't mind fixing them:
> ERROR: inline keyword should sit between storage class and type > #47: FILE: drivers/net/ethernet/intel/i40e/i40e_type.h:632: > +static bool inline i40e_is_fw_ver_ge(struct i40e_hw *hw, u16 maj, u16 min) > > ERROR: code indent should use tabs where possible > #49: FILE: drivers/net/ethernet/intel/i40e/i40e_type.h:634: > + return (hw->aq.fw_maj_ver > maj ||$ > > WARNING: please, no spaces at the start of a line > #49: FILE: drivers/net/ethernet/intel/i40e/i40e_type.h:634: > + return (hw->aq.fw_maj_ver > maj ||$ > > ERROR: code indent should use tabs where possible > #50: FILE: drivers/net/ethernet/intel/i40e/i40e_type.h:635: > + (hw->aq.fw_maj_ver == maj && hw->aq.fw_min_ver >= min));$ > > WARNING: please, no spaces at the start of a line > #50: FILE: drivers/net/ethernet/intel/i40e/i40e_type.h:635: > + (hw->aq.fw_maj_ver == maj && hw->aq.fw_min_ver >= min));$ > > ERROR: inline keyword should sit between storage class and type > #61: FILE: drivers/net/ethernet/intel/i40e/i40e_type.h:646: > +static bool inline i40e_is_fw_ver_lt(struct i40e_hw *hw, u16 maj, u16 min) > > ERROR: inline keyword should sit between storage class and type > #74: FILE: drivers/net/ethernet/intel/i40e/i40e_type.h:659: > +static bool inline i40e_is_fw_ver_eq(struct i40e_hw *hw, u16 maj, u16 min) > > ERROR: code indent should use tabs where possible > #76: FILE: drivers/net/ethernet/intel/i40e/i40e_type.h:661: > + return (hw->aq.fw_maj_ver > maj ||$ > > WARNING: please, no spaces at the start of a line > #76: FILE: drivers/net/ethernet/intel/i40e/i40e_type.h:661: > + return (hw->aq.fw_maj_ver > maj ||$ > > ERROR: code indent should use tabs where possible > #77: FILE: drivers/net/ethernet/intel/i40e/i40e_type.h:662: > + (hw->aq.fw_maj_ver == maj && hw->aq.fw_min_ver == min));$ > > WARNING: please, no spaces at the start of a line > #77: FILE: drivers/net/ethernet/intel/i40e/i40e_type.h:662: > + (hw->aq.fw_maj_ver == maj && hw->aq.fw_min_ver == min));$ > > total: 7 errors, 4 warnings, 0 checks, 60 lines checked >
Thanks, Jake
| |