Messages in this thread | | | Date | Tue, 24 Oct 2023 02:57:17 +0800 | From | kernel test robot <> | Subject | Re: [PATCH iwl-next 2/3] i40e: Add other helpers to check version of running firmware and AQ API |
| |
Hi Ivan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tnguy-next-queue/dev-queue]
url: https://github.com/intel-lab-lkp/linux/commits/Ivan-Vecera/i40e-Move-i40e_is_aq_api_ver_ge-helper/20231024-003221 base: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git dev-queue patch link: https://lore.kernel.org/r/20231023162928.245583-3-ivecera%40redhat.com patch subject: [PATCH iwl-next 2/3] i40e: Add other helpers to check version of running firmware and AQ API config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231024/202310240231.6eF5YKB4-lkp@intel.com/config) compiler: alpha-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231024/202310240231.6eF5YKB4-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202310240231.6eF5YKB4-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from drivers/net/ethernet/intel/i40e/i40e_dcb.h:7, from drivers/net/ethernet/intel/i40e/i40e.h:15, from drivers/net/ethernet/intel/i40e/i40e_main.c:13: >> drivers/net/ethernet/intel/i40e/i40e_type.h:632:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration] 632 | static bool inline i40e_is_fw_ver_ge(struct i40e_hw *hw, u16 maj, u16 min) | ^~~~~~ drivers/net/ethernet/intel/i40e/i40e_type.h:646:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration] 646 | static bool inline i40e_is_fw_ver_lt(struct i40e_hw *hw, u16 maj, u16 min) | ^~~~~~ drivers/net/ethernet/intel/i40e/i40e_type.h:659:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration] 659 | static bool inline i40e_is_fw_ver_eq(struct i40e_hw *hw, u16 maj, u16 min) | ^~~~~~ -- In file included from drivers/net/ethernet/intel/i40e/i40e_dcb.h:7, from drivers/net/ethernet/intel/i40e/i40e.h:15, from drivers/net/ethernet/intel/i40e/i40e_ptp.c:6: >> drivers/net/ethernet/intel/i40e/i40e_type.h:632:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration] 632 | static bool inline i40e_is_fw_ver_ge(struct i40e_hw *hw, u16 maj, u16 min) | ^~~~~~ drivers/net/ethernet/intel/i40e/i40e_type.h:646:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration] 646 | static bool inline i40e_is_fw_ver_lt(struct i40e_hw *hw, u16 maj, u16 min) | ^~~~~~ drivers/net/ethernet/intel/i40e/i40e_type.h:659:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration] 659 | static bool inline i40e_is_fw_ver_eq(struct i40e_hw *hw, u16 maj, u16 min) | ^~~~~~ drivers/net/ethernet/intel/i40e/i40e_ptp.c: In function 'i40e_ptp_init': drivers/net/ethernet/intel/i40e/i40e_ptp.c:1353:27: warning: '%s' directive output may be truncated writing up to 287 bytes into a region of size 64 [-Wformat-truncation=] 1353 | "%s", sdp_desc[i].name); | ^~ In function 'i40e_init_pin_config', inlined from 'i40e_ptp_create_clock' at drivers/net/ethernet/intel/i40e/i40e_ptp.c:1392:13, inlined from 'i40e_ptp_init' at drivers/net/ethernet/intel/i40e/i40e_ptp.c:1497:8: drivers/net/ethernet/intel/i40e/i40e_ptp.c:1351:17: note: 'snprintf' output between 1 and 288 bytes into a destination of size 64 1351 | snprintf(pf->ptp_caps.pin_config[i].name, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1352 | sizeof(pf->ptp_caps.pin_config[i].name), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1353 | "%s", sdp_desc[i].name); | ~~~~~~~~~~~~~~~~~~~~~~~
vim +/inline +632 drivers/net/ethernet/intel/i40e/i40e_type.h
623 624 /** 625 * i40e_is_fw_ver_ge 626 * @hw: pointer to i40e_hw structure 627 * @maj: API major value to compare 628 * @min: API minor value to compare 629 * 630 * Assert whether current firmware version is greater/equal than provided. 631 **/ > 632 static bool inline i40e_is_fw_ver_ge(struct i40e_hw *hw, u16 maj, u16 min) 633 { 634 return (hw->aq.fw_maj_ver > maj || 635 (hw->aq.fw_maj_ver == maj && hw->aq.fw_min_ver >= min)); 636 } 637
-- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
| |