Messages in this thread | | | Date | Sat, 21 Oct 2023 12:51:44 +0200 | From | Greg KH <> | Subject | Re: [PATCH v2] usb: typec: altmodes/displayport: verify compatible source/sink role combination |
| |
On Wed, Oct 18, 2023 at 08:34:09PM +0000, RD Babiera wrote: > DisplayPort Alt Mode CTS test 10.3.8 states that both sides of the > connection shall be compatible with one another such that the connection > is not Source to Source or Sink to Sink. > > The DisplayPort driver currently checks for a compatible pin configuration > that resolves into a source and sink combination. The CTS test is designed > to send a Discover Modes message that has a compatible pin configuration > but advertises the same port capability as the device; the current check > fails this. > > Verify that the port and port partner resolve into a valid source and sink > combination before checking for a compatible pin configuration. > > --- > Changes since v1: > * Fixed styling errors > * Added DP_CAP_IS_UFP_D and DP_CAP_IS_DFP_D as macros to typec_dp.h > ---
Git stops the changelog at the first "---", so everything below:
> Fixes: 0e3bb7d6894d ("usb: typec: Add driver for DisplayPort alternate mode") > Cc: stable@vger.kernel.org > Signed-off-by: RD Babiera <rdbabiera@google.com>
Is dropped, which is not what you want (did you try applying this yourself?)
As the documentation describes, please put the change information that you have here below this line:
> ---
So that it will not show up in the changelog.
Please fix up, add the reviews that you got, and submit a v3, as I can't take this one as-is :(
thanks,
greg k-h
| |