lkml.org 
[lkml]   [2023]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: greybus: camera: fixes alignment should match open parenthesis
On Fri, Oct 20, 2023 at 11:12:03PM +0800, Chen Shuo wrote:
> This patch fixes the checks reported by checkpatch.pl
> for alignment should match open parenthesis
>
> Signed-off-by: Chen Shuo <1289151713@qq.com>
> ---
> drivers/staging/greybus/camera.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
> index cdbb42cd413b..ed9e16bab4cc 100644
> --- a/drivers/staging/greybus/camera.c
> +++ b/drivers/staging/greybus/camera.c
> @@ -378,7 +378,7 @@ struct ap_csi_config_request {
> #define GB_CAMERA_CSI_CLK_FREQ_MARGIN 150000000U
>
> static int gb_camera_setup_data_connection(struct gb_camera *gcam,
> - struct gb_camera_configure_streams_response *resp,
> + struct gb_camera_configure_streams_response *resp,
> struct gb_camera_csi_params *csi_params)
> {

Just leave it as-is. The original was fine. I know that these days
we can go over the 80 character mark but, really, does this make things
easier to read?

regards,
dan carpenter

\
 
 \ /
  Last update: 2023-10-20 17:56    [W:0.035 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site