lkml.org 
[lkml]   [2023]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v13 6/8] media: dt-bindings: wave5: add Chips&Media 521c codec IP support
On Thu, Oct 12, 2023 at 03:24:12PM +0200, Krzysztof Kozlowski wrote:
> On 12/10/2023 13:01, Sebastian Fricke wrote:
> > From: Robert Beckett <bob.beckett@collabora.com>
> >
> > Add bindings for the chips&media wave5 codec driver
> >
> > Signed-off-by: Robert Beckett <bob.beckett@collabora.com>
> > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
> > Signed-off-by: Sebastian Fricke <sebastian.fricke@collabora.com>
> > ---
> > .../devicetree/bindings/media/cnm,wave5.yaml | 60 ++++++++++++++++++++++
> > 1 file changed, 60 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/cnm,wave5.yaml b/Documentation/devicetree/bindings/media/cnm,wave5.yaml
> > new file mode 100644
> > index 000000000000..b31d34aec05b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/cnm,wave5.yaml
> > @@ -0,0 +1,60 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/cnm,wave5.yaml#
>
> Filename matching compatible, so: cnm,cm521c-vpu.yaml
>
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Chips&Media Wave 5 Series multi-standard codec IP
> > +
> > +maintainers:
> > + - Nas Chung <nas.chung@chipsnmedia.com>
> > + - Jackson Lee <jackson.lee@chipsnmedia.com>
> > +
> > +description:
> > + The Chips&Media WAVE codec IP is a multi format video encoder/decoder
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - cnm,cm521c-vpu
>
> Can this device be anything else? Why VPU suffix?

It needs an SoC specific compatible (TI something...) as well (or
instead). Unless there's a public spec with details on how many
clocks, resets, interrupts, etc. there are.

Rob

\
 
 \ /
  Last update: 2023-10-16 15:48    [W:0.128 / U:0.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site