Messages in this thread | | | Date | Mon, 16 Oct 2023 10:40:35 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 -next] usb/usbip: fix wrong data added to platform device |
| |
On Sat, Oct 14, 2023 at 03:46:04PM +0800, Hongren Zheng wrote: > .data of platform_device_info will be copied into .platform_data of > struct device via platform_device_add_data.
platform_device_add_data()
> However, vhcis[i] contains a spinlock, is dynamically allocated and > used by other code, so it is not meant to be copied. The workaround > was to use void *vhci as an agent, but it was removed in the commit > suggested below. > > This patch adds back the workaround and changes the way of using > platform_data accordingly.
Good learning to me, thank you for the fix! Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
-- With Best Regards, Andy Shevchenko
| |