Messages in this thread | | | Date | Mon, 16 Oct 2023 11:19:41 -0600 | Subject | Re: [PATCH v2 -next] usb/usbip: fix wrong data added to platform device | From | Shuah Khan <> |
| |
On 10/16/23 01:40, Andy Shevchenko wrote: > On Sat, Oct 14, 2023 at 03:46:04PM +0800, Hongren Zheng wrote: >> .data of platform_device_info will be copied into .platform_data of >> struct device via platform_device_add_data. > > platform_device_add_data() > >> However, vhcis[i] contains a spinlock, is dynamically allocated and >> used by other code, so it is not meant to be copied. The workaround >> was to use void *vhci as an agent, but it was removed in the commit >> suggested below. >> >> This patch adds back the workaround and changes the way of using >> platform_data accordingly. > > Good learning to me, thank you for the fix! > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >
Thank you both.
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
thanks, -- Shuah
| |