Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Thu, 12 Oct 2023 16:44:08 +0200 | Subject | Re: [PATCH 5/6] arm64: dts: renesas: rzg3s-smarc: Enable SDHI1 |
| |
Hi Claudiu,
On Tue, Oct 10, 2023 at 3:27 PM Claudiu <claudiu.beznea@tuxon.dev> wrote: > From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > > Add SDHI1 to RZ/G3S Smarc Carrier-II board. This is connected to a uSD > interface. Although Vccq doesn't cross the boundary of SoM it has > been added to RZ/G3S Smarc Carrier-II dtsi to have all the bits related to > SDHI1 in a single place. At the moment SoM is used only with RZ/G3S Smarc > Carrier-II board. > > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi > +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi > @@ -11,6 +11,27 @@ > / { > aliases { > serial0 = &scif0; > + mmc1 = &sdhi1; > + }; > + > + /* Reserved regulators 0-9 for SoM. */ > + vcc_sdhi1: regulator10 {
You can use sensible names for the regulators to avoid conflicts. E.g. "regulator-vcc-sdhi1".
The rest LGTM.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |