Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Tue, 10 Oct 2023 19:39:43 +0200 | Subject | Re: [PATCH RFT v7 2/6] ARM: pxa: Convert Spitz LEDs to GPIO descriptors |
| |
On Tue, Oct 10, 2023 at 6:33 PM Duje Mihanović <duje.mihanovic@skole.hr> wrote: > > On Tuesday, October 10, 2023 1:12:05 PM CEST Bartosz Golaszewski wrote: > > Gah! I should have noticed this earlier but this is a perfect > > candidate for using hogs. Can you use gpiod_add_hogs() from > > linux/gpio/machine.h instead? That would save you having the lookup > > and the static leds descriptor array. > > From what I can tell, the hogs keep a certain pin at a certain state as long > as the machine is powered on. Is this really what we want to do with LEDs or > am I missing something? >
It doesn't seem like anyone is using these GPIOs once they're requested? Wouldn't the above definitios be analogous to:
GPIO_HOG("pxa-gpio", SPITZ_GPIO_LED_ORANGE, NULL, GPIO_ACTIVE_HIGH, GPIOD_ASIS) GPIO_HOG("pxa-gpio", SPITZ_GPIO_LED_GREEN, NULL, GPIO_ACTIVE_HIGH, GPIOD_ASIS)
?
Bart
| |