Messages in this thread | | | From | Alexander Lobakin <> | Subject | [PATCH v3 0/2] x86/boot: fix relying on link order | Date | Mon, 9 Jan 2023 18:04:01 +0100 |
| |
Currently, the x86 decompressor code expects the kernel entry point to be exactly at the beginning of the kernel image. It's always been true, but is hacky in multiple ways: special .head.text section and linking certain object files first to have them at the beginning. Make the code independent from the link order and then kill the latter. The former is to be resolved a bit later.
I didn't put any "Fixes:" tag since it's not linear. The lines changed with 0001 came from the initial x86 KASLR series, but that unconditional jump to the kernel beginning already was there. It goes at least from the set that brought relocatable kernel support to x86, but this is quite prehistoric already and might not look really relatable.
Alexander Lobakin (2): x86/boot: robustify calling startup_{32,64}() from the decompressor code scripts/head-object-list: remove x86 from the list
arch/x86/boot/compressed/head_32.S | 2 +- arch/x86/boot/compressed/head_64.S | 2 +- arch/x86/boot/compressed/misc.c | 18 +++++++++++------- scripts/head-object-list.txt | 6 ------ 4 files changed, 13 insertions(+), 15 deletions(-)
--- From v2[0]: * rebase on top of 6.2; * prettify debug entry point print.
From v1[1]: * collect the Tested-by tags (Jiri); * don't add pathetic returns after noreturn error() (Jiri); * debug-print the entry point offset via debug_putaddr() before booting (Jiri); * always have an empty line before return statements (Jiri).
[0] https://lore.kernel.org/all/20221101161529.1634188-1-alexandr.lobakin@intel.com [1] https://lore.kernel.org/all/20221031151047.167288-1-alexandr.lobakin@intel.com -- 2.39.0
| |