lkml.org 
[lkml]   [2023]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] tracing/eprobe: no need to check for negative ret value for snprintf
On Mon, 9 Jan 2023 23:59:13 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:

> On Mon, 9 Jan 2023 12:06:25 +0800
> Quanfa Fu <quanfafu@gmail.com> wrote:
>
> > No need to check for negative return value from snprintf() as the
> > code does not return negative values.
> >
>
> Thanks for simplifying, this looks good to me.
>
> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>

Masami, do you want to take it into the probes branch, or do you want me to
take it into the tracing branch?

-- Steve


>
> > Signed-off-by: Quanfa Fu <quanfafu@gmail.com>
> >

\
 
 \ /
  Last update: 2023-03-26 23:33    [W:0.040 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site