Messages in this thread Patch in this message | | | Date | Mon, 9 Jan 2023 11:43:35 -0800 | From | Benson Leung <> | Subject | Re: [PATCH 04/10] platform/chrome: cros_ec_typec: Set port alt mode drvdata |
| |
On Wed, Dec 28, 2022 at 12:45:07AM +0000, Prashant Malani wrote: > Save the ChromeOS-specific Type-C port info in the port altmodes' driver > data. This makes communication with the ChromeOS EC (Embedded > Controller) easier when alt mode drivers need to send messages to > peripherals. > > Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Signed-off-by: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Benson Leung <bleung@chromium.org>
> --- > drivers/platform/chrome/cros_ec_typec.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c > index bc8dc8bd90b3..05dc5a63af53 100644 > --- a/drivers/platform/chrome/cros_ec_typec.c > +++ b/drivers/platform/chrome/cros_ec_typec.c > @@ -345,6 +345,7 @@ static int cros_typec_register_port_altmodes(struct cros_typec_data *typec, > if (IS_ERR(amode)) > return PTR_ERR(amode); > port->port_altmode[CROS_EC_ALTMODE_DP] = amode; > + typec_altmode_set_drvdata(amode, port); > > /* > * Register TBT compatibility alt mode. The EC will not enter the mode > @@ -358,6 +359,7 @@ static int cros_typec_register_port_altmodes(struct cros_typec_data *typec, > if (IS_ERR(amode)) > return PTR_ERR(amode); > port->port_altmode[CROS_EC_ALTMODE_TBT] = amode; > + typec_altmode_set_drvdata(amode, port); > > port->state.alt = NULL; > port->state.mode = TYPEC_STATE_USB; > -- > 2.39.0.314.g84b9a713c41-goog > >
-- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org [unhandled content-type:application/pgp-signature] | |