Messages in this thread | | | Date | Mon, 2 Jan 2023 13:20:01 +0200 | From | Heikki Krogerus <> | Subject | Re: [PATCH 00/10] platform/chrome: cros_ec_typec: VDM support |
| |
On Wed, Dec 28, 2022 at 12:45:03AM +0000, Prashant Malani wrote: > This series adds support for sending and receiving USB PD Vendor > Defined Messages (VDMs) between the Application Processor's Type-C > ports and connected peripherals. > > Thir enables the Application processor to enter alternate modes and > process VDMs directly, instead of relying on state machines that exist > inside of co-processors like the ChromeOS Embedded Controller (EC). > > Patch 1/10 reverts an incorrect EC header modification. > Patch 2/10 to 5/10 update headers and existing Type-C structs to > accommodate the VDM code. > Patch 6/10 and 7/10 prepare the Type-C driver to have more than 1 file. > Patch 8/10 to 10/10 introduce the VDM functionality. > > Patch submissions suggestion (if approved): > - Even though Patch 1 touches drivers/mfd, it would be better to take > the entire series through the cbrome-platform branch, to avoid > cross-dependencies across maintainer trees.
For the whole series, FWIW:
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Prashant Malani (10): > Revert "mfd: cros_ec: Add SCP Core-1 as a new CrOS EC MCU" > platform_chrome: cros_ec: Add Type-C VDM defines > platform/chrome: cros_ec_typec: Stash port driver info > platform/chrome: cros_ec_typec: Set port alt mode drvdata > platform/chrome: cros_ec_typec: Update port DP VDO > platform/chrome: cros_ec_typec: Move structs to header > platform/chrome: cros_ec_typec: Alter module name with hyphens > platform/chrome: cros_ec_typec: Add initial VDM support > platform/chrome: cros_typec_vdm: Add VDM reply support > platform/chrome: cros_typec_vdm: Add VDM send support > > MAINTAINERS | 3 +- > drivers/mfd/cros_ec_dev.c | 5 - > drivers/platform/chrome/Kconfig | 2 +- > drivers/platform/chrome/Makefile | 3 +- > drivers/platform/chrome/cros_ec_typec.c | 91 +++------------ > drivers/platform/chrome/cros_ec_typec.h | 85 ++++++++++++++ > drivers/platform/chrome/cros_typec_vdm.c | 106 ++++++++++++++++++ > drivers/platform/chrome/cros_typec_vdm.h | 12 ++ > .../linux/platform_data/cros_ec_commands.h | 53 ++++++++- > include/linux/platform_data/cros_ec_proto.h | 1 - > 10 files changed, 276 insertions(+), 85 deletions(-) > create mode 100644 drivers/platform/chrome/cros_ec_typec.h > create mode 100644 drivers/platform/chrome/cros_typec_vdm.c > create mode 100644 drivers/platform/chrome/cros_typec_vdm.h
-- heikki
| |