lkml.org 
[lkml]   [2023]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2] soc: qcom: dcc: Signedness bug in config_reset_write()
From
On 1/5/23 4:53 AM, Dan Carpenter wrote:
> The "ret" variable needs to be signed for the error handling to work.

The fix looks good. I'm sorry I missed this one in review.

Reviewed-by: Alex Elder <elder@linaro.org>

>
> Fixes: 4cbe60cf5ad6 ("soc: qcom: dcc: Add driver support for Data Capture and Compare unit(DCC)")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> drivers/soc/qcom/dcc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/dcc.c b/drivers/soc/qcom/dcc.c
> index d4101f79cb5d..1e2cbefc1655 100644
> --- a/drivers/soc/qcom/dcc.c
> +++ b/drivers/soc/qcom/dcc.c
> @@ -808,8 +808,9 @@ static ssize_t config_reset_write(struct file *filp,
> const char __user *user_buf, size_t count,
> loff_t *ppos)
> {
> - unsigned int val, ret;
> + unsigned int val;
> struct dcc_drvdata *drvdata = filp->private_data;
> + int ret;
>
> ret = kstrtouint_from_user(user_buf, count, 0, &val);
> if (ret < 0)

\
 
 \ /
  Last update: 2023-03-26 23:28    [W:0.079 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site