Messages in this thread Patch in this message | | | Date | Thu, 5 Jan 2023 13:53:42 +0300 | From | Dan Carpenter <> | Subject | [PATCH 1/2] soc: qcom: dcc: Signedness bug in config_reset_write() |
| |
The "ret" variable needs to be signed for the error handling to work.
Fixes: 4cbe60cf5ad6 ("soc: qcom: dcc: Add driver support for Data Capture and Compare unit(DCC)") Signed-off-by: Dan Carpenter <error27@gmail.com> --- drivers/soc/qcom/dcc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/qcom/dcc.c b/drivers/soc/qcom/dcc.c index d4101f79cb5d..1e2cbefc1655 100644 --- a/drivers/soc/qcom/dcc.c +++ b/drivers/soc/qcom/dcc.c @@ -808,8 +808,9 @@ static ssize_t config_reset_write(struct file *filp, const char __user *user_buf, size_t count, loff_t *ppos) { - unsigned int val, ret; + unsigned int val; struct dcc_drvdata *drvdata = filp->private_data; + int ret; ret = kstrtouint_from_user(user_buf, count, 0, &val); if (ret < 0) -- 2.35.1
| |