Messages in this thread | | | Date | Thu, 5 Jan 2023 22:55:12 +0100 | From | Horatiu Vultur <> | Subject | Re: [PATCH net-next v3 4/4] net: lan966x: Add ptp trap rules |
| |
The 01/05/2023 16:09, Michael Walle wrote: > > Hi,
Hi Michael,
> > > > Also, if the answer to my question above is yes, and ptp should > > > have worked on eth0 before, this is a regression then. > > > > OK, I can see your point. > > With the following diff, you should see the same behaviour as before: > > --- > > diff --git > > a/drivers/net/ethernet/microchip/lan966x/lan966x_vcap_impl.c > > b/drivers/net/ethernet/microchip/lan966x/lan966x_vcap_impl.c > > index 904f5a3f636d3..538f4b76cf97a 100644 > > --- a/drivers/net/ethernet/microchip/lan966x/lan966x_vcap_impl.c > > +++ b/drivers/net/ethernet/microchip/lan966x/lan966x_vcap_impl.c > > @@ -91,8 +91,6 @@ lan966x_vcap_is2_get_port_keysets(struct net_device > > *dev, int lookup, > > > > /* Check if the port keyset selection is enabled */ > > val = lan_rd(lan966x, ANA_VCAP_S2_CFG(port->chip_port)); > > - if (!ANA_VCAP_S2_CFG_ENA_GET(val)) > > - return -ENOENT; > > > > /* Collect all keysets for the port in a list */ > > if (l3_proto == ETH_P_ALL) > > Any news on this? Apart from the patches which would change the > need to use some tc magic, this should be a separate fixes patch, > right?
My colleague Steen, has sent a patch series here [1]. This allows to PTP rules in HW without any tc commands.
[1] https://lore.kernel.org/lkml/20230105081335.1261636-1-steen.hegelund@microchip.com/T/
> > -michael
-- /Horatiu
| |