Messages in this thread | | | Date | Wed, 4 Jan 2023 10:23:39 +0100 | Subject | Re: [PATCH] remoteproc/mtk_scp: Move clk ops outside send_lock | From | AngeloGioacchino Del Regno <> |
| |
Il 04/01/23 09:31, Chen-Yu Tsai ha scritto: > Clocks are properly reference counted and do not need to be inside the > lock range. > > Right now this triggers a false-positive lockdep warning on MT8192 based > Chromebooks, through a combination of mtk-scp that has a cros-ec-rpmsg > sub-device, the (actual) cros-ec I2C adapter registration, I2C client > (not on cros-ec) probe doing i2c transfers and enabling clocks. > > This is a false positive because the cros-ec-rpmsg under mtk-scp does > not have an I2C adapter, and also each I2C adapter and cros-ec instance > have their own mutex. > > Move the clk operations outside of the send_lock range. > > Fixes: ("63c13d61eafe remoteproc/mediatek: add SCP support for mt8183") > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Nice catch.
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
| |