Messages in this thread | | | From | Chen-Yu Tsai <> | Date | Thu, 5 Jan 2023 17:03:21 +0800 | Subject | Re: [PATCH] remoteproc/mtk_scp: Move clk ops outside send_lock |
| |
On Wed, Jan 4, 2023 at 4:31 PM Chen-Yu Tsai <wenst@chromium.org> wrote: > > Clocks are properly reference counted and do not need to be inside the > lock range. > > Right now this triggers a false-positive lockdep warning on MT8192 based > Chromebooks, through a combination of mtk-scp that has a cros-ec-rpmsg > sub-device, the (actual) cros-ec I2C adapter registration, I2C client > (not on cros-ec) probe doing i2c transfers and enabling clocks. > > This is a false positive because the cros-ec-rpmsg under mtk-scp does > not have an I2C adapter, and also each I2C adapter and cros-ec instance > have their own mutex. > > Move the clk operations outside of the send_lock range.
Well this managed to untangle the lockdep warning a bit, but it still appears. I'll keep looking into it.
| |