lkml.org 
[lkml]   [2023]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Subject[PATCH v3 0/8] Follow-up patches for uvc v4l2-compliance
From
Date
This patchset contains the fixes for the comments on "v10 of Fix
v4l2-compliance errors series". In particular to the patches

-uvcvideo: uvc_ctrl_is_accessible: check for INACTIVE
-uvcvideo: improve error handling in uvc_query_ctrl()

And the patch:
-uvcvideo: Fix handling on Bitmask controls

To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>

---
Changes in v3 (Thanks Laurent):
- Add a new patch for refactoring __uvc_ctrl_add_mapping
- Use standard names for menus
- Return error on uvc_mapping_get_menu_value
- Add const
- StyLe!
- Do not return positive errors in uvc_query_ctrl()
- Improve commit message
- improve error logging in uvc_query_ctrl()
- Fix comment
- Improve doc
- Fix handling on Bitmask controls
- s/uvc/UVC
- Reflow comments to 80 chars
- Test with GET_RES first
- Remove clamp to (0,..)
- Return -EACCES for Wrong state error
- Full rewrite of commit message
- uvc_ctrl_is_accessible: check for INACTIVE
- Update commit message
- Remove try variable
- Update documentation
- Implement mask for V4L2_CTRL_TYPE_MENU
- Include linux/bits.h
- Link to v2: https://lore.kernel.org/r/20220920-resend-v4l2-compliance-v2-0-7c0942040004@chromium.org

Changes in v2:
- Include "Get menu names from framework series"
https://lore.kernel.org/r/20220920-standard-menues-v2-0-a35af3243c2f@chromium.org
- Link to v1: https://lore.kernel.org/r/20220920-resend-v4l2-compliance-v1-0-81364c15229b@chromium.org

---
Hans Verkuil (2):
media: uvcvideo: Check for INACTIVE in uvc_ctrl_is_accessible()
media: uvcvideo: improve error logging in uvc_query_ctrl()

Ricardo Ribalda (6):
media: uvcvideo: Return -EACCES for Wrong state error
media: uvcvideo: Do not return positive errors in uvc_query_ctrl()
media: uvcvideo: Fix handling on Bitmask controls
media: uvcvideo: Implement mask for V4L2_CTRL_TYPE_MENU
media: uvcvideo: Refactor __uvc_ctrl_add_mapping
media: uvcvideo: Use standard names for menus

drivers/media/usb/uvc/uvc_ctrl.c | 238 ++++++++++++++++++++++++++++---------
drivers/media/usb/uvc/uvc_driver.c | 10 +-
drivers/media/usb/uvc/uvc_v4l2.c | 108 ++++++++++++-----
drivers/media/usb/uvc/uvc_video.c | 15 +--
drivers/media/usb/uvc/uvcvideo.h | 8 +-
include/uapi/linux/uvcvideo.h | 4 +-
6 files changed, 281 insertions(+), 102 deletions(-)
---
base-commit: 69b41ac87e4a664de78a395ff97166f0b2943210
change-id: 20220920-resend-v4l2-compliance-4fdbe4fbd7b5

Best regards,
--
Ricardo Ribalda <ribalda@chromium.org>

\
 
 \ /
  Last update: 2023-03-26 23:25    [W:0.135 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site