lkml.org 
[lkml]   [2023]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] ca8210: move to gpio descriptors
From
Hello Arnd.

On 26.01.23 17:25, Arnd Bergmann wrote:
> On Thu, Jan 26, 2023, at 17:17, Arnd Bergmann wrote:
>
>> if (ret) {
>> - dev_crit(&spi->dev, "request_irq %d failed\n", pdata->irq_id);
>> - gpiod_unexport(gpio_to_desc(pdata->gpio_irq));
>> - gpio_free(pdata->gpio_irq);
>> + dev_crit(&spi->dev, "request_irq %d failed\n", priv->irq_id);
>> + gpiod_put(priv->gpio_irq);
>> }
>
> I just realized that this bit depends on the "gpiolib: remove
> legacy gpio_export" patch I sent to the gpio mailing list earlier.
>
> We can probably just defer this change until that is merged,
> or alternatively I can rebase this patch to avoid the
> dependency.

Deferring the change until i picked it up from Linus or net-next in my
tree is fine. This driver is not heavily worked on (its actually marked
as orphaned) so the patch should still apply in a few days.

I will keep it in my patchwork queue of patches to be applied. No extra
work needed from your side.

regards
Stefan Schmidt

\
 
 \ /
  Last update: 2023-03-27 00:00    [W:0.060 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site