Messages in this thread | | | Date | Thu, 26 Jan 2023 17:25:29 +0100 | From | "Arnd Bergmann" <> | Subject | Re: [PATCH] ca8210: move to gpio descriptors |
| |
On Thu, Jan 26, 2023, at 17:17, Arnd Bergmann wrote:
> if (ret) { > - dev_crit(&spi->dev, "request_irq %d failed\n", pdata->irq_id); > - gpiod_unexport(gpio_to_desc(pdata->gpio_irq)); > - gpio_free(pdata->gpio_irq); > + dev_crit(&spi->dev, "request_irq %d failed\n", priv->irq_id); > + gpiod_put(priv->gpio_irq); > }
I just realized that this bit depends on the "gpiolib: remove legacy gpio_export" patch I sent to the gpio mailing list earlier.
We can probably just defer this change until that is merged, or alternatively I can rebase this patch to avoid the dependency.
Arnd
| |