Messages in this thread | | | From | Linus Walleij <> | Date | Fri, 27 Jan 2023 14:15:35 +0100 | Subject | Re: [PATCH 6/8] gpiolib: split linux/gpio/driver.h out of linux/gpio.h |
| |
On Thu, Jan 26, 2023 at 2:28 PM Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de> > > Almost all gpio drivers include linux/gpio/driver.h, and other > files should not rely on includes from this header. > > Remove the indirect include from here and include the correct > headers directly from where they are used. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Makes the kernel look better after than before so: Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
I was going to send this to Bartosz but don't want us falling over each other, however consider the approach I use to get rid of <linux/gpio/driver.h> here: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/log/?h=gpiochip-no-driver-h (My patch set was at least approved by the build bots.)
Comparing the approaches it seems you need these two, feel free to cherry-pick to avoid build errors from the bots: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/commit/?h=gpiochip-no-driver-h&id=89f4f9cc70c686303679e57bdc3ac86507979fe3 https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/commit/?h=gpiochip-no-driver-h&id=73ca8058a7b2075c993040bdc92b6a82f57d4316
Yours, Linus Walleij
| |