Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Fri, 27 Jan 2023 10:41:53 +0100 | Subject | Re: [PATCH 2/8] gpiolib: coldfire: remove custom asm/gpio.h |
| |
On Thu, Jan 26, 2023 at 2:28 PM Arnd Bergmann <arnd@kernel.org> wrote: > > From: Arnd Bergmann <arnd@arndb.de> > > Now that coldfire is the only user of a custom asm/gpio.h, it seems > better to remove this as well, and have the same interface everywhere. > > For the gpio_get_value()/gpio_set_value()/gpio_to_irq(), gpio_cansleep() > functions, the custom version is only a micro-optimization to inline the > function for constant GPIO numbers. However, in the coldfire defconfigs, > I was unable to find a single instance where this micro-optimization > was even used, and according to Geert the only user appears to be the > QSPI chip that is disabled everywhere. > > The custom gpio_request_one() function is even less useful, as it is > guarded by an #ifdef that is never true. > > Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > ---
Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
| |