Messages in this thread | | | From | Linus Walleij <> | Date | Thu, 26 Jan 2023 21:01:00 +0100 | Subject | Re: [PATCH v1 3/5] usb: fotg210-udc: remove redundant error logging |
| |
On Fri, Jan 20, 2023 at 4:44 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> A call to platform_get_irq() already prints an error on failure within > its own implementation. So printing another error based on its return > value in the caller is redundant and should be removed. The clean up > also makes if condition block braces unnecessary. Remove that as well. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |