Messages in this thread | | | From | Linus Walleij <> | Date | Thu, 16 Feb 2023 09:30:23 +0100 | Subject | Re: [PATCH v1 4/5] usb: fotg210: Switch to use dev_err_probe() |
| |
On Thu, Feb 16, 2023 at 9:07 AM Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> > - dev_err(dev, "init %s fail, %d\n", dev_name(dev), retval); > > - return retval; > > + return dev_err_probe(dev, retval, "init %s fail\n", dev_name(dev)); > > Hi, > the patch is already applied, but is dev_name(dev) needed here?
Not really but it's not a big deal either, it's just a string. Feel free to send an incremental patch dropping it :)
Yours, Linus Walleij
| |