Messages in this thread | | | Date | Tue, 17 Jan 2023 08:05:38 -0800 | From | Ashok Raj <> | Subject | Re: [PATCH v4 4/6] x86/microcode/intel: Use a plain revision argument for print_ucode_rev() |
| |
On Sun, Jan 15, 2023 at 08:39:18PM +0100, Borislav Petkov wrote: > On Mon, Jan 09, 2023 at 07:35:53AM -0800, Ashok Raj wrote: > > @@ -334,7 +331,7 @@ void show_ucode_info_early(void) > > > > if (delay_ucode_info) { > > intel_cpu_collect_info(&uci); > > - print_ucode_info(&uci, current_mc_date); > > + print_ucode_info(uci.cpu_sig.rev. current_mc_date); > > You must be kidding:
Oversight completely.. Apologize. I remember seeing them but unfortunately I ended up fixing the issue in patch5 instead of patch4.
> > arch/x86/kernel/cpu/microcode/intel.c: In function ‘show_ucode_info_early’: > arch/x86/kernel/cpu/microcode/intel.c:332:49: error: request for member ‘current_mc_date’ in something not a structure or union > 332 | print_ucode_info(uci.cpu_sig.rev. current_mc_date); > | ^ > arch/x86/kernel/cpu/microcode/intel.c:332:17: error: too few arguments to function ‘print_ucode_info’ > 332 | print_ucode_info(uci.cpu_sig.rev. current_mc_date); > | ^~~~~~~~~~~~~~~~ > arch/x86/kernel/cpu/microcode/intel.c:311:13: note: declared here > 311 | static void print_ucode_info(unsigned int new_rev, unsigned int date) > | ^~~~~~~~~~~~~~~~ > arch/x86/kernel/cpu/microcode/intel.c: In function ‘print_ucode’: > arch/x86/kernel/cpu/microcode/intel.c:343:33: error: unused variable ‘mc’ [-Werror=unused-variable] > 343 | struct microcode_intel *mc; > | ^~
I fixed in patch6 instead of this patch, my bad.
I updated my build to have CONFIG_WERROR, i had that accidently turned off in one of my configs.
I have fixed up the right version and can repost if there are no additional comments.
Cheers, Ashok
| |