Messages in this thread | | | Date | Fri, 13 Jan 2023 15:56:59 +0100 | Subject | Re: [PATCH v2 0/4] soc: qcom: Introduce PMIC GLINK | From | Konrad Dybcio <> |
| |
On 13.01.2023 05:11, Bjorn Andersson wrote: > This implements the base PMIC GLINK driver, a power_supply driver and a > driver for the USB Type-C altmode protocol. This has been tested and > shown to provide battery information, USB Type-C switch and mux requests > and DisplayPort notifications on SC8180X, SC8280XP and SM8350. > For the series:
Tested-by: Konrad Dybcio <konrad.dybcio@linaro.org> # SM8350 PDX215
Thanks a lot for working on this!
One thing, /sys/class/power_supply/qcom-battmgr-usb/input_current_limit is stuck at zero and so is the current_now as a result (the voltage readout is 5V + some noise, so that looks good), but I don't see any SET paths for it in the driver, so I suppose that's what the firmware default is?
Konrad
> Bjorn Andersson (4): > dt-bindings: soc: qcom: Introduce PMIC GLINK binding > soc: qcom: pmic_glink: Introduce base PMIC GLINK driver > soc: qcom: pmic_glink: Introduce altmode support > power: supply: Introduce Qualcomm PMIC GLINK power supply > > .../bindings/soc/qcom/qcom,pmic-glink.yaml | 102 ++ > drivers/power/supply/Kconfig | 9 + > drivers/power/supply/Makefile | 1 + > drivers/power/supply/qcom_battmgr.c | 1421 +++++++++++++++++ > drivers/soc/qcom/Kconfig | 15 + > drivers/soc/qcom/Makefile | 2 + > drivers/soc/qcom/pmic_glink.c | 336 ++++ > drivers/soc/qcom/pmic_glink_altmode.c | 477 ++++++ > include/linux/soc/qcom/pmic_glink.h | 32 + > 9 files changed, 2395 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml > create mode 100644 drivers/power/supply/qcom_battmgr.c > create mode 100644 drivers/soc/qcom/pmic_glink.c > create mode 100644 drivers/soc/qcom/pmic_glink_altmode.c > create mode 100644 include/linux/soc/qcom/pmic_glink.h >
| |