| Date | Fri, 13 Jan 2023 09:45:19 +0100 (CET) | From | Geert Uytterhoeven <> | Subject | Re: [PATCH 13/22] pinctrl: remove renesas sh controllers |
| |
Hi Christoph,
On Fri, 13 Jan 2023, Christoph Hellwig wrote: > Now that arch/sh is removed these drivers are dead code. > > Signed-off-by: Christoph Hellwig <hch@lst.de>
Thanks for your patch!
> --- a/drivers/pinctrl/renesas/Kconfig > +++ b/drivers/pinctrl/renesas/Kconfig > @@ -255,57 +243,10 @@ config PINCTRL_RZV2M > This selects GPIO and pinctrl driver for Renesas RZ/V2M > platforms. > > -config PINCTRL_PFC_SH7203 > - bool "pin control support for SH7203" if COMPILE_TEST > - select PINCTRL_SH_FUNC_GPIO
(If this is to be continued) the PINCTRL_SH_FUNC_GPIO symbol itself, and all its users, can be removed, too.
> --- a/drivers/pinctrl/renesas/core.c > +++ b/drivers/pinctrl/renesas/core.c > @@ -753,562 +753,6 @@ static int sh_pfc_suspend_init(struct sh_pfc *pfc) { return 0; } > #define DEV_PM_OPS NULL > #endif /* CONFIG_PM_SLEEP && CONFIG_ARM_PSCI_FW */ > > -#ifdef DEBUG > -#define SH_PFC_MAX_REGS 300 > -#define SH_PFC_MAX_ENUMS 5000 > -
This whole hunk should stay (except for the part protected by #ifdef CONFIG_PINCTRL_SH_FUNC_GPIO), as it is used for validating pin control tables on ARM SoCs, too.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
|