Messages in this thread | | | Date | Fri, 13 Jan 2023 18:21:09 +0100 | Subject | Re: [PATCH 3/3] thermal/drivers/intel: Use generic trip points int340x | From | Daniel Lezcano <> |
| |
Hi Srinivas,
On 13/01/2023 16:48, srinivas pandruvada wrote: > Hi Daniel, > >>>> > > [...] > >>>> - status = acpi_evaluate_integer(d->adev->handle, "GTSH", >>>> NULL, >>>> &hyst); >>>> - if (ACPI_FAILURE(status)) >>>> - *temp = 0; >>>> - else >>>> - *temp = hyst * 100; >>> >>> The previous code returns hyst * 100. >>> But the new API retuurns hyst directly. >>> >>> -/sys/class/thermal/thermal_zone2/trip_point_4_hyst:2000 >>> +/sys/class/the >>> rmal/thermal_zone2/trip_point_4_hyst:20 >>> >>> Is this done on purpose? >> >> No, it is an error. The function thermal_acpi_trip_gtsh() should do: >> >> return deci_kelvin_to_millicelsius(hyst); >> >> > > GTSH returns here in tenths of degree Kelvin. For example 15 means 1.5 > degree K.
Yes, so the above conversion is correct, right ?
> I would like to test your next series with thermald. If there is a > problem, it will break every distro.
Great, thanks!
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |