Messages in this thread | | | Subject | Re: [PATCH 3/3] thermal/drivers/intel: Use generic trip points int340x | From | srinivas pandruvada <> | Date | Fri, 13 Jan 2023 07:48:59 -0800 |
| |
Hi Daniel,
> > >
[...]
> > > - status = acpi_evaluate_integer(d->adev->handle, "GTSH", > > > NULL, > > > &hyst); > > > - if (ACPI_FAILURE(status)) > > > - *temp = 0; > > > - else > > > - *temp = hyst * 100; > > > > The previous code returns hyst * 100. > > But the new API retuurns hyst directly. > > > > -/sys/class/thermal/thermal_zone2/trip_point_4_hyst:2000 > > +/sys/class/the > > rmal/thermal_zone2/trip_point_4_hyst:20 > > > > Is this done on purpose? > > No, it is an error. The function thermal_acpi_trip_gtsh() should do: > > return deci_kelvin_to_millicelsius(hyst); > >
GTSH returns here in tenths of degree Kelvin. For example 15 means 1.5 degree K.
I would like to test your next series with thermald. If there is a problem, it will break every distro.
Thanks, Srinivas
> >
| |