Messages in this thread Patch in this message | | | From | Randy Dunlap <> | Subject | [PATCH] misc: genwqe: move intervening macros away from kernel-doc | Date | Thu, 12 Jan 2023 22:39:09 -0800 |
| |
Don't separate a function's kernel-doc comment and its definition with macros or data; move the macro and data ahead of the function and its comments to prevent a warning:
drivers/misc/genwqe/card_utils.c:162: warning: expecting prototype for genwqe_init_crc32(). Prototype was for CRC32_POLYNOMIAL() instead
Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Frank Haverkamp <haver@linux.ibm.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/misc/genwqe/card_utils.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff -- a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c --- a/drivers/misc/genwqe/card_utils.c +++ b/drivers/misc/genwqe/card_utils.c @@ -151,6 +151,9 @@ int genwqe_read_app_id(struct genwqe_dev return i; } +#define CRC32_POLYNOMIAL 0x20044009 +static u32 crc32_tab[256]; /* crc32 lookup table */ + /** * genwqe_init_crc32() - Prepare a lookup table for fast crc32 calculations * @@ -159,9 +162,6 @@ int genwqe_read_app_id(struct genwqe_dev * * Genwqe's Polynomial = 0x20044009 */ -#define CRC32_POLYNOMIAL 0x20044009 -static u32 crc32_tab[256]; /* crc32 lookup table */ - void genwqe_init_crc32(void) { int i, j;
| |