Messages in this thread | | | Date | Fri, 9 Sep 2022 17:27:07 +0300 | Subject | Re: [PATCH 02/16] phy: qcom-qmp-combo: drop unused defines | From | Dmitry Baryshkov <> |
| |
On 09/09/2022 16:20, Johan Hovold wrote: > On Fri, Sep 09, 2022 at 12:21:12PM +0300, Dmitry Baryshkov wrote: >> On 07/09/2022 14:07, Johan Hovold wrote: >>> Drop defines and enums that are unused since the QMP driver split. >>> >>> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> >>> --- >>> drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 15 --------------- >>> 1 file changed, 15 deletions(-) >>> >>> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c >>> index 9ce2ab56be4c..838f7e328b55 100644 >>> --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c >>> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c >>> @@ -28,16 +28,11 @@ >>> #define SW_RESET BIT(0) >>> /* QPHY_POWER_DOWN_CONTROL */ >>> #define SW_PWRDN BIT(0) >>> -#define REFCLK_DRV_DSBL BIT(1) >>> /* QPHY_START_CONTROL bits */ >>> #define SERDES_START BIT(0) >>> #define PCS_START BIT(1) >>> -#define PLL_READY_GATE_EN BIT(3) >>> /* QPHY_PCS_STATUS bit */ >>> #define PHYSTATUS BIT(6) >>> -#define PHYSTATUS_4_20 BIT(7) >>> -/* QPHY_PCS_READY_STATUS & QPHY_COM_PCS_READY_STATUS bit */ >>> -#define PCS_READY BIT(0) >> >> I think these defines, describing registers and bits, can go to the >> common header instead. > > Adding those to a common header can be done later if needed at all (and > would include adding a proper prefix etc).
Ack, let's sort them out later, if Vinod agrees with this.
> >> For the rest of the patch: >> >> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Johan
-- With best wishes Dmitry
| |