Messages in this thread Patch in this message | | | From | "Guilherme G. Piccoli" <> | Subject | [PATCH V2] efi: efibc: Guard against allocation failure | Date | Fri, 9 Sep 2022 16:42:14 -0300 |
| |
There is a single kmalloc in this driver, and it's not currently guarded against allocation failure. Do it here by just bailing-out the reboot handler, in case this tentative allocation fails.
Fixes: 416581e48679 ("efi: efibc: avoid efivar API for setting variables") Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com> ---
V2: * Rebased against 6.0-rc4; * Dropped from the original series [0].
[0] https://lore.kernel.org/linux-efi/20220729194532.228403-1-gpiccoli@igalia.com/
drivers/firmware/efi/efibc.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/firmware/efi/efibc.c b/drivers/firmware/efi/efibc.c index 8ced7af8e56d..4f9fb086eab7 100644 --- a/drivers/firmware/efi/efibc.c +++ b/drivers/firmware/efi/efibc.c @@ -48,6 +48,9 @@ static int efibc_reboot_notifier_call(struct notifier_block *notifier, return NOTIFY_DONE; wdata = kmalloc(MAX_DATA_LEN * sizeof(efi_char16_t), GFP_KERNEL); + if (!wdata) + return NOTIFY_DONE; + for (l = 0; l < MAX_DATA_LEN - 1 && str[l] != '\0'; l++) wdata[l] = str[l]; wdata[l] = L'\0'; -- 2.37.2
| |