Messages in this thread | | | Subject | Re: [PATCH] net: prestera: acl: Add check for kmemdup | From | Joe Perches <> | Date | Fri, 30 Sep 2022 11:28:09 -0700 |
| |
On Fri, 2022-09-30 at 09:58 -0700, Jakub Kicinski wrote: > On Fri, 30 Sep 2022 09:43:54 -0700 Joe Perches wrote: > > > > There's no great way to identify "author" or "original submitter" > > > > and frequently the "original submitter" isn't a maintainer anyway. > > > > > > Confusing sentence. We want for people who s-o-b'd the commit under > > > Fixes to be CCed. > > > > If a file or a file modified by a patch is listed in the MAINTAINERS, > > git history isn't used unless --git is specified. > > > > For a patch, maybe the author and other SOBs of a commit specified > > by a "Fixes:" line SHA-1 in the commit message could be added automatically. > > Yes, git history isn't used, but the Fixes tag are consulted already > AFAICT. We just need to steer people towards running the script on > the patch. > > $ git format-patch net/main~..net/main -o /tmp/ > /tmp/0001-eth-alx-take-rtnl_lock-on-resume.patch > > $ grep Fixes /tmp/0001-eth-alx-take-rtnl_lock-on-resume.patch > Fixes: 4a5fe57e7751 ("alx: use fine-grained locking instead of RTNL") > > $ git show 4a5fe57e7751 --pretty='%an <%ae>' --no-patch > Johannes Berg <johannes@sipsolutions.net> > > $ ./scripts/get_maintainer.pl /tmp/0001-eth-alx-take-rtnl_lock-on-resume.patch | grep blame > "David S. Miller" <davem@davemloft.net> (maintainer:NETWORKING DRIVERS,commit_signer:2/4=50%,blamed_fixes:1/1=100%) > Johannes Berg <johannes@sipsolutions.net> (blamed_fixes:1/1=100%)
Yeah, you kinda ruined my reveal. It already does that.
Of course I did that 3 years ago and I forgot about it.
cheers, Joe
| |