lkml.org 
[lkml]   [2022]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] module: Remove unused macros module_addr_min/max
Hi,

On Sat, 24 Sep 2022, Chen Zhongjin wrote:

> Unused macros reported by [-Wunused-macros].
>
> These macros are introduced to record the bound address of modules.
>
> '80b8bf436990 ("module: Always have struct mod_tree_root")'
> This commit has made struct mod_tree_root always exist, which means
> we can always referencing mod_tree derectly rather than using this
> macro.
>
> So they are useless, remove them for code cleaning.

a nit, but I would rephrase the changelog a bit...

"
Commit 80b8bf436990 ("module: Always have struct mod_tree_root") made
"struct mod_tree_root" always present and its members addr_min and
addr_max can be directly accessed.

Macros module_addr_min and module_addr_min are not used anymore, so remove
them.
"

> Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>

Anyway

Reviewed-by: Miroslav Benes <mbenes@suse.cz>

M

\
 
 \ /
  Last update: 2022-09-30 13:45    [W:0.047 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site