Messages in this thread | | | Date | Fri, 30 Sep 2022 13:37:25 +0200 (CEST) | From | Miroslav Benes <> | Subject | Re: [PATCH -next] module: Remove unused macros module_addr_min/max |
| |
Hi,
On Sat, 24 Sep 2022, Chen Zhongjin wrote:
> Unused macros reported by [-Wunused-macros]. > > These macros are introduced to record the bound address of modules. > > '80b8bf436990 ("module: Always have struct mod_tree_root")' > This commit has made struct mod_tree_root always exist, which means > we can always referencing mod_tree derectly rather than using this > macro. > > So they are useless, remove them for code cleaning.
a nit, but I would rephrase the changelog a bit...
" Commit 80b8bf436990 ("module: Always have struct mod_tree_root") made "struct mod_tree_root" always present and its members addr_min and addr_max can be directly accessed.
Macros module_addr_min and module_addr_min are not used anymore, so remove them. "
> Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>
Anyway
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
M
| |