lkml.org 
[lkml]   [2022]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH -next] module: Remove unused macros module_addr_min/max
Date


Le 24/09/2022 à 09:22, Chen Zhongjin a écrit :
> Unused macros reported by [-Wunused-macros].
>
> These macros are introduced to record the bound address of modules.
>
> '80b8bf436990 ("module: Always have struct mod_tree_root")'
> This commit has made struct mod_tree_root always exist, which means
> we can always referencing mod_tree derectly rather than using this
> macro.
>
> So they are useless, remove them for code cleaning.

Yeah, it looks like this removal got lost during a rebase.
Should have been part of 55ce556dbf92 ("module: Remove module_addr_min
and module_addr_max")

Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>

>
> Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>
> ---
> kernel/module/main.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/kernel/module/main.c b/kernel/module/main.c
> index a4e4d84b6f4e..96dcc950da60 100644
> --- a/kernel/module/main.c
> +++ b/kernel/module/main.c
> @@ -84,9 +84,6 @@ struct mod_tree_root mod_data_tree __cacheline_aligned = {
> };
> #endif
>
> -#define module_addr_min mod_tree.addr_min
> -#define module_addr_max mod_tree.addr_max
> -
> struct symsearch {
> const struct kernel_symbol *start, *stop;
> const s32 *crcs;
\
 
 \ /
  Last update: 2022-09-26 07:50    [W:0.066 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site