| Date | Fri, 30 Sep 2022 10:07:47 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH printk 09/18] serial: kgdboc: Lock console list in probe function |
| |
On Sat 2022-09-24 02:10:45, John Ogness wrote: > From: Thomas Gleixner <tglx@linutronix.de> > > Unprotected list walks are not necessarily safe. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > Signed-off-by: John Ogness <john.ogness@linutronix.de> > Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
It looks correct in principle. There is still a discussion [1] whether to introduce console_list_lock() or use the existing console_lock(), see https://lore.kernel.org/r/20220924000454.3319186-7-john.ogness@linutronix.de
Depending on the result of the discussion, with either console_list_lock() or console_lock():
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards, Petr
|