Messages in this thread | | | Date | Fri, 7 Oct 2022 11:11:42 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH printk 13/18] printk: Move buffer size defines |
| |
On Sat 2022-09-24 02:10:49, John Ogness wrote: > From: Thomas Gleixner <tglx@linutronix.de> > > Move the buffer size defines to console.h in preparation of adding a buffer > structure. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > Signed-off-by: John Ogness <john.ogness@linutronix.de> > --- > include/linux/console.h | 14 ++++++++++++++ > include/linux/printk.h | 2 -- > kernel/printk/printk.c | 8 -------- > 3 files changed, 14 insertions(+), 10 deletions(-) > > diff --git a/include/linux/console.h b/include/linux/console.h > index dc0df9d9e7d9..3bb5bc62e154 100644 > --- a/include/linux/console.h > +++ b/include/linux/console.h > @@ -122,6 +122,20 @@ static inline int con_debug_leave(void) > #define CM_ERASE (2) > #define CM_MOVE (3) > > +#ifdef CONFIG_PRINTK > +/* The maximum size of a formatted record (i.e. with prefix added per line) */ > +#define CONSOLE_LOG_MAX 1024 > + > +/* The maximum size for a dropped text message */ > +#define DROPPED_TEXT_MAX 64 > +#else > +#define CONSOLE_LOG_MAX 0 > +#define DROPPED_TEXT_MAX 0 > +#endif > + > +/* The maximum size of an formatted extended record */ > +#define CONSOLE_EXT_LOG_MAX 8192
It seems that all these defines are going to be used only under kernel/printk/. I would prefer to move them into kernel/printk/internal.h or another internal header file there.
Any public API can be misused. And these are rather implementation details.
Best Regards, Petr
| |