Messages in this thread | | | Date | Fri, 30 Sep 2022 15:27:44 -0700 | Subject | [syzbot] possible deadlock in ntfs_read_block | From | syzbot <> |
| |
Hello,
syzbot found the following issue on:
HEAD commit: bbed346d5a96 Merge branch 'for-next/core' into for-kernelci git tree: git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci console output: https://syzkaller.appspot.com/x/log.txt?x=1163743f080000 kernel config: https://syzkaller.appspot.com/x/.config?x=aae2d21e7dd80684 dashboard link: https://syzkaller.appspot.com/bug?extid=780dbcbee0942e16bcb6 compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2 userspace arch: arm64 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=15c18400880000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=16e4dbc4880000
Downloadable assets: disk image: https://storage.googleapis.com/syzbot-assets/11078f50b80b/disk-bbed346d.raw.xz vmlinux: https://storage.googleapis.com/syzbot-assets/398e5f1e6c84/vmlinux-bbed346d.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+780dbcbee0942e16bcb6@syzkaller.appspotmail.com
====================================================== WARNING: possible circular locking dependency detected 6.0.0-rc7-syzkaller-18095-gbbed346d5a96 #0 Not tainted ------------------------------------------------------ kworker/u4:4/317 is trying to acquire lock: ffff0000ca1008c0 (&rl->lock){++++}-{3:3}, at: ntfs_read_block+0x2d0/0x1110 fs/ntfs/aops.c:248
but task is already holding lock: ffff0000ca103010 (&ni->mrec_lock){+.+.}-{3:3}, at: map_mft_record+0x40/0xfc fs/ntfs/mft.c:154
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (&ni->mrec_lock){+.+.}-{3:3}: __mutex_lock_common+0xd4/0xca8 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 map_mft_record+0x40/0xfc fs/ntfs/mft.c:154 ntfs_truncate+0xd8/0xf6c fs/ntfs/inode.c:2376 ntfs_truncate_vfs fs/ntfs/inode.c:2855 [inline] ntfs_setattr+0x1ac/0x228 fs/ntfs/inode.c:2907 notify_change+0x758/0x7f0 fs/attr.c:420 do_truncate+0x108/0x150 fs/open.c:65 vfs_truncate+0x1dc/0x24c fs/open.c:111 do_sys_truncate+0x94/0x140 fs/open.c:134 __do_sys_truncate fs/open.c:146 [inline] __se_sys_truncate fs/open.c:144 [inline] __arm64_sys_truncate+0x20/0x30 fs/open.c:144 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall arch/arm64/kernel/syscall.c:52 [inline] el0_svc_common+0x138/0x220 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x48/0x164 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x150 arch/arm64/kernel/entry-common.c:636 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:654 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581
-> #0 (&rl->lock){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3095 [inline] check_prevs_add kernel/locking/lockdep.c:3214 [inline] validate_chain kernel/locking/lockdep.c:3829 [inline] __lock_acquire+0x1530/0x30a4 kernel/locking/lockdep.c:5053 lock_acquire+0x100/0x1f8 kernel/locking/lockdep.c:5666 down_read+0x5c/0x78 kernel/locking/rwsem.c:1499 ntfs_read_block+0x2d0/0x1110 fs/ntfs/aops.c:248 ntfs_read_folio+0x594/0x758 fs/ntfs/aops.c:436 filemap_read_folio+0x68/0x33c mm/filemap.c:2394 do_read_cache_folio+0x1c8/0x588 mm/filemap.c:3519 do_read_cache_page mm/filemap.c:3561 [inline] read_cache_page+0x40/0x178 mm/filemap.c:3570 read_mapping_page include/linux/pagemap.h:756 [inline] ntfs_map_page fs/ntfs/aops.h:75 [inline] ntfs_sync_mft_mirror+0xb4/0x109c fs/ntfs/mft.c:480 write_mft_record_nolock+0x814/0xc70 fs/ntfs/mft.c:787 write_mft_record+0xe4/0x230 fs/ntfs/mft.h:95 __ntfs_write_inode+0x32c/0x554 fs/ntfs/inode.c:3043 ntfs_write_inode+0x3c/0x4c fs/ntfs/super.c:2655 write_inode fs/fs-writeback.c:1440 [inline] __writeback_single_inode+0x240/0x2e4 fs/fs-writeback.c:1652 writeback_sb_inodes+0x3e4/0x85c fs/fs-writeback.c:1865 wb_writeback+0x198/0x328 fs/fs-writeback.c:2039 wb_do_writeback+0xc8/0x384 fs/fs-writeback.c:2182 wb_workfn+0x70/0x15c fs/fs-writeback.c:2222 process_one_work+0x2d8/0x504 kernel/workqueue.c:2289 worker_thread+0x340/0x610 kernel/workqueue.c:2436 kthread+0x12c/0x158 kernel/kthread.c:376 ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:860
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1 ---- ---- lock(&ni->mrec_lock); lock(&rl->lock); lock(&ni->mrec_lock); lock(&rl->lock);
*** DEADLOCK ***
3 locks held by kworker/u4:4/317: #0: ffff0000c0dbc538 ((wq_completion)writeback){+.+.}-{0:0}, at: process_one_work+0x270/0x504 kernel/workqueue.c:2262 #1: ffff8000127a3d80 ((work_completion)(&(&wb->dwork)->work)){+.+.}-{0:0}, at: process_one_work+0x29c/0x504 kernel/workqueue.c:2264 #2: ffff0000ca103010 (&ni->mrec_lock){+.+.}-{3:3}, at: map_mft_record+0x40/0xfc fs/ntfs/mft.c:154
stack backtrace: CPU: 0 PID: 317 Comm: kworker/u4:4 Not tainted 6.0.0-rc7-syzkaller-18095-gbbed346d5a96 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/26/2022 Workqueue: writeback wb_workfn (flush-7:0) Call trace: dump_backtrace+0x1c4/0x1f0 arch/arm64/kernel/stacktrace.c:156 show_stack+0x2c/0x54 arch/arm64/kernel/stacktrace.c:163 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x104/0x16c lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x2c4/0x2c8 kernel/locking/lockdep.c:2053 check_noncircular+0x14c/0x154 kernel/locking/lockdep.c:2175 check_prev_add kernel/locking/lockdep.c:3095 [inline] check_prevs_add kernel/locking/lockdep.c:3214 [inline] validate_chain kernel/locking/lockdep.c:3829 [inline] __lock_acquire+0x1530/0x30a4 kernel/locking/lockdep.c:5053 lock_acquire+0x100/0x1f8 kernel/locking/lockdep.c:5666 down_read+0x5c/0x78 kernel/locking/rwsem.c:1499 ntfs_read_block+0x2d0/0x1110 fs/ntfs/aops.c:248 ntfs_read_folio+0x594/0x758 fs/ntfs/aops.c:436 filemap_read_folio+0x68/0x33c mm/filemap.c:2394 do_read_cache_folio+0x1c8/0x588 mm/filemap.c:3519 do_read_cache_page mm/filemap.c:3561 [inline] read_cache_page+0x40/0x178 mm/filemap.c:3570 read_mapping_page include/linux/pagemap.h:756 [inline] ntfs_map_page fs/ntfs/aops.h:75 [inline] ntfs_sync_mft_mirror+0xb4/0x109c fs/ntfs/mft.c:480 write_mft_record_nolock+0x814/0xc70 fs/ntfs/mft.c:787 write_mft_record+0xe4/0x230 fs/ntfs/mft.h:95 __ntfs_write_inode+0x32c/0x554 fs/ntfs/inode.c:3043 ntfs_write_inode+0x3c/0x4c fs/ntfs/super.c:2655 write_inode fs/fs-writeback.c:1440 [inline] __writeback_single_inode+0x240/0x2e4 fs/fs-writeback.c:1652 writeback_sb_inodes+0x3e4/0x85c fs/fs-writeback.c:1865 wb_writeback+0x198/0x328 fs/fs-writeback.c:2039 wb_do_writeback+0xc8/0x384 fs/fs-writeback.c:2182 wb_workfn+0x70/0x15c fs/fs-writeback.c:2222 process_one_work+0x2d8/0x504 kernel/workqueue.c:2289 worker_thread+0x340/0x610 kernel/workqueue.c:2436 kthread+0x12c/0x158 kernel/kthread.c:376 ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:860
--- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller@googlegroups.com.
syzbot will keep track of this issue. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. syzbot can test patches for this issue, for details see: https://goo.gl/tpsmEJ#testing-patches
| |