Messages in this thread Patch in this message | | | From | Li Zhong <> | Subject | [PATCH v2] ata: libata-core: Check errors in sata_print_link_status() | Date | Sat, 3 Sep 2022 16:10:39 -0700 |
| |
sata_scr_read() could return negative error code on failure. Check the return value when reading the control register.
Signed-off-by: Li Zhong <floridsleeves@gmail.com> --- drivers/ata/libata-core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 826d41f341e4..ae08c7d35cb0 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -3021,7 +3021,8 @@ static void sata_print_link_status(struct ata_link *link) if (sata_scr_read(link, SCR_STATUS, &sstatus)) return; - sata_scr_read(link, SCR_CONTROL, &scontrol); + if (sata_scr_read(link, SCR_CONTROL, &scontrol)) + return; if (ata_phys_link_online(link)) { tmp = (sstatus >> 4) & 0xf; -- 2.25.1
| |