Messages in this thread | | | Date | Sat, 3 Sep 2022 11:41:39 -0700 | Subject | Re: [PATCH] clk: iproc: Do not rely on node name for correct PLL setup | From | Florian Fainelli <> |
| |
On 8/2/2022 7:58 PM, Florian Fainelli wrote: > After commit 31fd9b79dc58 ("ARM: dts: BCM5301X: update CRU block > description") a warning from clk-iproc-pll.c was generated due to a > duplicate PLL name as well as the console stopped working. Upon closer > inspection it became clear that iproc_pll_clk_setup() used the Device > Tree node unit name as an unique identifier as well as a parent name to > parent all clocks under the PLL. > > BCM5301X was the first platform on which that got noticed because of the > DT node unit name renaming but the same assumptions hold true for any > user of the iproc_pll_clk_setup() function. > > The first 'clock-output-names' property is always guaranteed to be > unique as well as providing the actual desired PLL clock name, so we > utilize that to register the PLL and as a parent name of all children > clock. > > Fixes: 5fe225c105fd ("clk: iproc: add initial common clock support") > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Stephen,
Can we get this applied for an upcoming 6.0-rc? Thanks -- Florian
| |