Messages in this thread | | | Date | Wed, 28 Sep 2022 18:01:40 +0200 | Subject | Re: [PATCH 05/13] phy: qcom-qmp-pcie: unify sdm845 registers | From | Neil Armstrong <> |
| |
On 28/09/2022 17:28, Johan Hovold wrote: > The SDM845 register array is identical to pciephy_regs_layout so drop > the former. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c > index 7b3f7e42edd5..4146545fdf5f 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c > @@ -92,12 +92,6 @@ static const unsigned int pciephy_regs_layout[QPHY_LAYOUT_SIZE] = { > [QPHY_PCS_STATUS] = 0x174, > }; > > -static const unsigned int sdm845_qmp_pciephy_regs_layout[QPHY_LAYOUT_SIZE] = { > - [QPHY_SW_RESET] = 0x00, > - [QPHY_START_CTRL] = 0x08, > - [QPHY_PCS_STATUS] = 0x174, > -}; > - > static const unsigned int sdm845_qhp_pciephy_regs_layout[QPHY_LAYOUT_SIZE] = { > [QPHY_SW_RESET] = 0x00, > [QPHY_START_CTRL] = 0x08, > @@ -1545,7 +1539,7 @@ static const struct qmp_phy_cfg sdm845_qmp_pciephy_cfg = { > .num_resets = ARRAY_SIZE(sdm845_pciephy_reset_l), > .vreg_list = qmp_phy_vreg_l, > .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), > - .regs = sdm845_qmp_pciephy_regs_layout, > + .regs = pciephy_regs_layout, > > .start_ctrl = PCS_START | SERDES_START, > .pwrdn_ctrl = SW_PWRDN | REFCLK_DRV_DSBL,
Isn't is an issue if QPHY_COM_* entries are in pciephy_regs_layout and not in sdm845_qmp_pciephy_regs_layout ?
BTW it seems those QPHY_COM_* are never used..
Neil
| |