Messages in this thread | | | Date | Wed, 28 Sep 2022 22:10:02 +0300 | Subject | Re: [PATCH 06/13] phy: qcom-qmp-pcie: drop bogus register update | From | Dmitry Baryshkov <> |
| |
On 28/09/2022 18:28, Johan Hovold wrote: > Since commit 0d58280cf1e6 ("phy: Update PHY power control sequence") the > PHY is powered on before configuring the registers and only the MSM8996 > PCIe PHY, which includes the POWER_DOWN_CONTROL register in its PCS > initialisation table, may possibly require a second update afterwards. > > To make things worse, the POWER_DOWN_CONTROL register lies at a > different offset on more recent SoCs so that the second update, which > still used a hard-coded offset, would write to an unrelated register > (e.g. a revision-id register on SC8280XP). > > As the MSM8996 PCIe PHY is now handled by a separate driver, simply drop > the bogus register update. > > Fixes: e4d8b05ad5f9 ("phy: qcom-qmp: Use proper PWRDOWN offset for sm8150 USB") added support
I'm not sure about the particular fixes tag. Backporting from the split driver into old qmp driver would be a complete pain.
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> --- > drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c > index 4146545fdf5f..eea66c24cf7e 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c > @@ -1953,12 +1953,6 @@ static int qmp_pcie_power_on(struct phy *phy) > qmp_pcie_configure(pcs_misc, cfg->regs, cfg->pcs_misc_tbl, cfg->pcs_misc_tbl_num); > qmp_pcie_configure(pcs_misc, cfg->regs, cfg->pcs_misc_tbl_sec, cfg->pcs_misc_tbl_num_sec); > > - /* > - * Pull out PHY from POWER DOWN state. > - * This is active low enable signal to power-down PHY. > - */ > - qphy_setbits(pcs, QPHY_V2_PCS_POWER_DOWN_CONTROL, cfg->pwrdn_ctrl); > - > if (cfg->has_pwrdn_delay) > usleep_range(cfg->pwrdn_delay_min, cfg->pwrdn_delay_max); >
-- With best wishes Dmitry
| |