Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 28 Sep 2022 14:10:44 +0300 | Subject | Re: [PATCH v3 3/4] Documentation: rs485: Mention uart_get_rs485_mode() |
| |
On Wed, Sep 28, 2022 at 2:05 PM Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> wrote: > > Add to rs485 documentation that serial core prepares the struct > serial_rs485 when uart_get_rs485_mode() is called. Remove the wrong > claim that driver must fill it by itself.
the driver
...
> The device tree can also provide RS485 boot time parameters > - [#DT-bindings]_. The driver is in charge of filling this data structure > - from the values given by the device tree. > + [#DT-bindings]_. The serial core fills the struct serial_rs485 from the > + values given by the device tree when driver calls uart_get_rs485_mode().
the driver
Feels like this should be before the previous patch and actually have a Fixes tag.
-- With Best Regards, Andy Shevchenko
| |