lkml.org 
[lkml]   [2022]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH linux-next] net: atm: Convert to use sysfs_emit()/sysfs_emit_at() APIs
Date
From: zhang songyi <zhang.songyi@zte.com.cn>

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the value
to be returned to user space.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
---
net/atm/atm_sysfs.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/net/atm/atm_sysfs.c b/net/atm/atm_sysfs.c
index 0fdbdfd19474..2258d94288a6 100644
--- a/net/atm/atm_sysfs.c
+++ b/net/atm/atm_sysfs.c
@@ -16,7 +16,7 @@ static ssize_t type_show(struct device *cdev,
{
struct atm_dev *adev = to_atm_dev(cdev);

- return scnprintf(buf, PAGE_SIZE, "%s\n", adev->type);
+ return sysfs_emit(buf, "%s\n", adev->type);
}

static ssize_t address_show(struct device *cdev,
@@ -24,7 +24,7 @@ static ssize_t address_show(struct device *cdev,
{
struct atm_dev *adev = to_atm_dev(cdev);

- return scnprintf(buf, PAGE_SIZE, "%pM\n", adev->esi);
+ return sysfs_emit(buf, "%pM\n", adev->esi);
}

static ssize_t atmaddress_show(struct device *cdev,
@@ -37,7 +37,7 @@ static ssize_t atmaddress_show(struct device *cdev,

spin_lock_irqsave(&adev->lock, flags);
list_for_each_entry(aaddr, &adev->local, entry) {
- count += scnprintf(buf + count, PAGE_SIZE - count,
+ count += sysfs_emit_at(buf, count,
"%1phN.%2phN.%10phN.%6phN.%1phN\n",
&aaddr->addr.sas_addr.prv[0],
&aaddr->addr.sas_addr.prv[1],
@@ -55,7 +55,7 @@ static ssize_t atmindex_show(struct device *cdev,
{
struct atm_dev *adev = to_atm_dev(cdev);

- return scnprintf(buf, PAGE_SIZE, "%d\n", adev->number);
+ return sysfs_emit(buf, "%d\n", adev->number);
}

static ssize_t carrier_show(struct device *cdev,
@@ -63,7 +63,7 @@ static ssize_t carrier_show(struct device *cdev,
{
struct atm_dev *adev = to_atm_dev(cdev);

- return scnprintf(buf, PAGE_SIZE, "%d\n",
+ return sysfs_emit(buf, "%d\n",
adev->signal == ATM_PHY_SIG_LOST ? 0 : 1);
}

@@ -87,7 +87,7 @@ static ssize_t link_rate_show(struct device *cdev,
default:
link_rate = adev->link_rate * 8 * 53;
}
- return scnprintf(buf, PAGE_SIZE, "%d\n", link_rate);
+ return sysfs_emit(buf, "%d\n", link_rate);
}

static DEVICE_ATTR_RO(address);
--
2.25.1

\
 
 \ /
  Last update: 2022-09-27 08:47    [W:0.038 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site